This probably needs to be moved to the BTS, Teams/Dpkg/RoadMap and/or the Teams/Dpkg/Contribute pages.
Stuff to review, update and merge
Those lists are ordered and used by the dpkg maintainers to track external contributions that needs to be reviewed and merged.
Feel free to add new entries at the end of the table in "Review queue" (before the sample entry). Move it to the end of "Merge queue" only when you're confident that it had sufficient review/testing to be merged. Dpkg maintainers might move it back to "Needs work" if they find issues they want to see resolved prior to the merge.
When providing new code to review/merge, it's also a good idea to review some of the other pending patches/branches: the dpkg maintainers have difficulties keeping up with all the reviews requested and peer reviews saves valuable time of the dpkg maintainers who can then concentrate on the contributions that are mostly ready to be merged.
Merge queue
Title |
Bug/Git links |
Proposer |
Status |
History |
Sample entry |
Your name |
The current status |
Review queue
Title |
Bug/Git links |
Proposer |
Status |
History |
Remember presence of epoch 0 when parsing versions |
Raphaël Hertzog |
Needs reviews |
2010-05-02: Initial proposal |
|
Failed install followed by failed remove results in installed state |
Raphael Hertzog/Colin Watson/Ian Jackson |
Needs tests and review |
|
|
capability dropping in start-stop-daemon |
Nicolas Bareil |
Needs review |
|
|
Sample entry |
Your name |
The current status |
Note: All bugs in this list should have the "patch" tag.
Needs work
Title |
Bug/Git links |
Proposer |
Status |
History |
Check reverse dependencies on unpack |
|
Breaks in some cases |
|
|
Dselect track seen packages |
|
Needs discussion with other front-ends maintainers |
|
|
Use UTF-8 internally, convert on output |
|
Patch is 7 years old |
|
|
Dselect UTF-8 support |
|
Update and tests needed and must decide if libtextwrap dependency is ok |
|
|
Improved conffile merge |
|
Unknown |
|
|
Translated field names |
|
Patch from 1999 |
|
|
dpkg -S and symlinks |
Raphaël Hertzog, feel free to adopt |
Needs update and review |
|
|
Setting ulimit form start-stop-daemon |
|
Must be updated along comments |
|
|
support for ad-hoc architecture definitions |
Simon Richter |
Needs design decision |
|
|
Sample entry |
Your name |
The current status |
Nobody Note: All bugs in this list should have their "patch" tag removed unless someone is actively working towards updating the patch. Entries where the proposer is set to nobody need someone to adopt the patch and help get it working.
Review guidelines
When reviewing other's people code, here are the stuff that you should pay attention too:
does it respect the coding style?
does the modified dpkg still pass all the tests in dpkg-tests.git?
- does it provide new non-regression tests to prove that nothing related got broken by the change?
- does the patch apply on the main branch?
- is the design sane?
- does it properly reuse existing code?
- should some parts be integrated in libdpkg?
- is the code portable?
- does it update the manual pages accordingly?
- is the code correctly documented (including Doxygen meta-information where relevant)?